Skip to content

Fix for GetJobAsync deserialization issue#1461

Merged
WhitWaldo merged 3 commits intodapr:masterfrom
WhitWaldo:get-jobs-fix
Feb 19, 2025
Merged

Fix for GetJobAsync deserialization issue#1461
WhitWaldo merged 3 commits intodapr:masterfrom
WhitWaldo:get-jobs-fix

Conversation

@WhitWaldo
Copy link
Copy Markdown
Contributor

Description

When retrieving the data from GetJobAsync, the dueTime wasn't properly deserializing. It was originally written expecting a null value if the dueTime isn't populated, but in practice this returns an empty string, so the null check doesn't catch the actual value. Updated to use string.IsNullOrWhitespace which will catch more invalid values in the property.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1460

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • [N/A] Created/updated tests - Going to add some E2E testing around this as it needs actual values from the runtime to validate
  • [N/A] Extended the documentation

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.15 milestone Feb 19, 2025
@WhitWaldo WhitWaldo self-assigned this Feb 19, 2025
@WhitWaldo WhitWaldo requested review from a team as code owners February 19, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetJobAsync calls failure

2 participants