Remove unnecessary replace statements in go.mod
#2185
Conversation
Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
|
/ok-to-test |
Components conformance testCommit ref: 5e896ec ❌ Some conformance tests failedThese tests failed:
|
Components certification testCommit ref: 5e896ec ❌ Some certification tests failedThese tests failed:
|
|
|
||
| replace k8s.io/client => github.com/kubernetes-client/go v0.0.0-20190928040339-c757968c4c36 | ||
|
|
||
| replace github.com/eclipse/paho.mqtt.golang => github.com/shivamkm07/paho.mqtt.golang v1.3.6-0.20220106130409-e28a1db639f8 |
There was a problem hiding this comment.
Why is this not upstream already? It is unacceptable to use @shivamkm07's personal fork for so many months. We need to find a different strategy.
There was a problem hiding this comment.
Latest version is 1.4.1 and we are stuck on this unmaintained 1.3.6 fork.
There was a problem hiding this comment.
Can you complete work on eclipse-paho/paho.mqtt.golang#578 @shivamkm07 ?
There was a problem hiding this comment.
@berndverst Updated the PR as requested. Waiting for the maintainers' response. Thanks!
Signed-off-by: Bernd Verst <[email protected]>
|
/ok-to-test |
Components conformance testCommit ref: c6b888e ✅ All conformance tests passedAll tests have reported a successful status |
Components certification testCommit ref: c6b888e ❌ Some certification tests failedThese tests failed:
|
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
+ Coverage 37.38% 37.42% +0.03%
==========================================
Files 191 191
Lines 24884 24884
==========================================
+ Hits 9304 9313 +9
+ Misses 14859 14849 -10
- Partials 721 722 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4 participants
Description
Remove unnecessary replace statements in
go.mod