Skip to content

Conversation

@scotscotmcc
Copy link
Contributor

The dependency versions in pyproject.toml limit pandas and textual versions, requiring a finicky, manual process to install via pip with newer versions of those libraries.

My (very basic) testing indicates that textual-pandas works fine with pandas==2.2.3 and with textual==3.0.1, the newest versions of each of those.

The main textual library is using a versions scheme where the major version will change if there are breaking changes plus that library is frequently updated, so I figure that textual-pandas will likely work fine for any 3.x.x.

The pandas version I put more conservatively here... I would actually expect that to be very stable for this, but new pandas versions are only a few times a year.

Increase pandas version to <=2.2.3 and textual version to <4.0
@dannywade
Copy link
Owner

Thank you for pointing this out! With the the textual library changing so much, I'd like to bump up the minimum version as well. I tested some changes locally by bumping up the minimum version of textual to 1.0, which required bumping up my min. Python version to 3.10. Can you test with the following dependency versions in pyproject.toml?

[tool.poetry.dependencies]
python = ">=3.10,<4.0"
textual = "<4.0, >=1.0"
pandas = "<=2.2.3"

If it works, please update the the poetry.lock file and we can merge.

update dependency versions
rebuild poetry with updated dependency versions
@scotscotmcc
Copy link
Contributor Author

I updated the dependency versions to what you have above and tried that out with my project and it worked. My project has textual==3.1.0, pandas==2.2.3, and has python==3.13.2 (and a bunch of other unrelated stuff), and I was able to also install textual-pandas with these updates without any dependency issues and there were no problems with the application that I saw.

I also did update the poetry.lock file but, to be honest, I've never used poetry before. So I just did a pip install poetry and then poetry lock and it updated that file. The poetry version I used was just whatever pip installed by default, which was poetry==2.1.2 while it looked like the old version was in 2.0 (as evidence by the metadata.lock-version changing from 2.0 to 2.1 in the 3rd-to-last line in poetry.lock). So, hope I did that right!

@dannywade dannywade merged commit b8d327a into dannywade:main Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants