Remove DataFrameTable.__init__
#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the full set of DataTable initialisation arguments to be
passed through via DataFrameTable. See
https://textual.textualize.io/widgets/data_table/#textual.widgets.DataTable
for the parameters that people may wish to be using. This means that
DataFrameTable is now a drop-in replacement for DataTable.
If DataFrameTable does need to grow its own __init__ it would be a good idea
to carry all of those arguments through.
Owner
|
A little late here but merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the full set of
DataTableinitialisation arguments to be passed through viaDataFrameTable. This means thatDataFrameTableis now a drop-in replacement forDataTable.If
DataFrameTabledoes need to grow its own__init__it would be a good idea to carry all of those arguments through.