Merged
Conversation
xrchz
reviewed
Nov 4, 2022
| for (uint32_t blob_index = 0; blob_index < blobs_count; blob_index++) { | ||
| Napi::Value blob = blobs_param[blob_index]; | ||
| auto blob_bytes = blob.As<Napi::Uint8Array>().Data(); | ||
| memcpy(blobs[blob_index], blob_bytes, BYTES_PER_BLOB); |
Collaborator
There was a problem hiding this comment.
this copying is unfortunate - does passing blobs_param more directly not work? (like in the python version). not a big deal if you have to copy though.
Author
There was a problem hiding this comment.
Agreed. I have tried a bunch of things but can't figure out anything other than memcpy.
blobs_param is of type Napi::Array. I've been googling and trying things. Nothing so far is working.
xrchz
reviewed
Nov 4, 2022
xrchz
reviewed
Nov 4, 2022
xrchz
approved these changes
Nov 4, 2022
Collaborator
xrchz
left a comment
There was a problem hiding this comment.
Assuming the bindings actually build and work (I haven't tested) this looks great to me.
…tely on verify_kzg_proof failure
7 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds NodeJS bindings with the following interface:
I also added blst as a submodule.
Most of diff is a yarn lockfile.
Test instructions: README