Skip to content

RLE fix#182

Merged
daniel5151 merged 2 commits intodaniel5151:masterfrom
mrexodia:rle-fix
Jan 24, 2026
Merged

RLE fix#182
daniel5151 merged 2 commits intodaniel5151:masterfrom
mrexodia:rle-fix

Conversation

@mrexodia
Copy link
Contributor

Description

Fixed a bug in the RLE encoding where a $ would be inserted in the packet when encoding 00000000. This happened when implementing the library list which contained a base with zeroes in it.

API Stability

  • This PR does not require a breaking API change

Checklist

  • Documentation
    • Ensured any public-facing rustdoc formatting looks good (via cargo doc)
    • (if appropriate) Added feature to "Debugging Features" in README.md
  • Validation
    • Included output of running examples/armv4t with RUST_LOG=trace + any relevant GDB output under the "Validation" section below
    • Included output of running ./example_no_std/check_size.sh before/after changes under the "Validation" section below
  • If implementing a new protocol extension IDET
    • Included a basic sample implementation in examples/armv4t
    • IDET can be optimized out (confirmed via ./example_no_std/check_size.sh)
    • OR implementation requires introducing non-optional binary bloat (please elaborate under "Description")
  • If upstreaming an Arch implementation
    • I have tested this code in my project, and to the best of my knowledge, it is working as intended.

Validation

Added tests to make sure both $ and # are not in the RLE packet. Can remove if overkill.

@mrexodia mrexodia changed the title Rle fix RLE fix Jan 23, 2026
Copy link
Owner

@daniel5151 daniel5151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm astonished this bug has hid itself for so long, hah.

Thanks for sending in this fix (and tests)!

@daniel5151 daniel5151 merged commit 7a959e7 into daniel5151:master Jan 24, 2026
2 checks passed
@mrexodia mrexodia deleted the rle-fix branch January 24, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants