Add support for qThreadExtraInfo#106
Merged
daniel5151 merged 1 commit intodaniel5151:masterfrom Jun 8, 2022
Merged
Conversation
daniel5151
requested changes
Jun 8, 2022
Owner
daniel5151
left a comment
There was a problem hiding this comment.
All in all, this is looking good!
e31f252 to
ebaa9de
Compare
Contributor
Author
|
I think I've addressed all the feedback - let me know if there's any additional items you'd like to see addressed |
bet4it
suggested changes
Jun 8, 2022
Comment on lines
+25
to
+26
| let mut body = body.splitn_mut_no_panic(3, |b| *b == b','); | ||
| let id = SpecificThreadId::try_from(ThreadId::try_from(body.next()?).ok()?).ok()?; |
Contributor
There was a problem hiding this comment.
Suggested change
| let mut body = body.splitn_mut_no_panic(3, |b| *b == b','); | |
| let id = SpecificThreadId::try_from(ThreadId::try_from(body.next()?).ok()?).ok()?; | |
| let id = SpecificThreadId::try_from(ThreadId::try_from(body).ok()?).ok()?; |
0dd8086 to
c6d81b1
Compare
daniel5151
requested changes
Jun 8, 2022
Owner
daniel5151
left a comment
There was a problem hiding this comment.
Looks good.
It's a bit late for me here, so I'll give it one last once-over in the morning just in case, but it should be good to go after resolving this last thing.
Add a new sub-IDET for `MultiThreadBase` to respond with extra information about a thread Signed-off-by: Ryan Fairfax <[email protected]>
c6d81b1 to
2e148ea
Compare
Owner
|
Thanks again for the contribution! Once #103 lands, I'll push out |
11 tasks
Owner
|
@thefaxman 0.6.2 has been released :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new sub-IDET for
MultiThreadBaseto respond with extra information about a thread.Closes #104
API Stability
Checklist
cargo buildcompiles withouterrorsorwarningscargo clippyruns withouterrorsorwarningscargo fmtwas runexamples/armv4texamples/armv4twithRUST_LOG=trace+ any relevant GDB output under the "Validation" section below./scripts/test_dead_code_elim.shand/or./example_no_std/check_size.sh)Validation
GDB output
armv4t output