Serve Apple app site association file#7191
Merged
dani-garcia merged 1 commit intoMay 17, 2026
Merged
Conversation
dani-garcia
approved these changes
May 17, 2026
dani-garcia
left a comment
Owner
There was a problem hiding this comment.
Can't test it but it looks reasonable enough, thanks!
2 tasks
zaid-marji
pushed a commit
to zaid-marji/vaultwarden
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serve
/.well-known/apple-app-site-associationfrom vaultwarden.Right now the request falls through to the web vault catch-all route:
#[get("/<p..>", rank = 10)]That route takes a
PathBuf, and Rocket rejects.well-knownbefore the static file lookup runs. The result is a422 Unprocessable Entityinstead of an AASA response.Changes
GET /.well-known/apple-app-site-associationroute before the catch-all web vault route.Content-Type: application/json.LTZ2PFU5D6.com.8bit.bitwardenLTZ2PFU5D6.com.8bit.bitwarden.betaNotes
I'm keeping this scoped to the server-side endpoint. This fixes the
422response for the AASA URL, but it does not claim to fully solve every iOS passkey/auth-loop case by itself.Verification
I checked the route behavior with a minimal Rocket reproduction using the same catch-all route shape.
Before adding an explicit route:
After adding the explicit route:
I also ran:
Finally, I ran the repository CI on my fork for commit
399742b; all checks passed:Refs #7186