Fix pattern for detecting SwiftLint in package #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danger-Swift uses SwiftLint in the package when it contains, which takes too much times to fetch and build.
There is a repo which only contains plugins (https://github.com/SimplyDanny/SwiftLintPlugins),
swift run swiftlintis fail when the package conatins it instead of SwiftLint directly.However, current spec causes failure ( try to run
swift run swiftlintand fail ) becausematches to
This PR fixes a regex to avoid false positive of
SwiftLintPlugins.This is a test case
