Add wavelength means Observation to analyze_spectral function#964
Merged
Add wavelength means Observation to analyze_spectral function#964
Conversation
nfahlgren
approved these changes
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 141 129 -12
Lines 6011 5813 -198
==========================================
- Hits 6011 5813 -198
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
There was duplicate observations of global standard deviation within the
pcv.hyperspectral.analyze_spectralfunction when we probably intended to include the wavelength averages calculated earlier in the function and then plotted out. This PR resolves these bugs and renamed the variable to be more accurate throughout the function.Type of update
Is this a:
Associated issues
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md