Skip to content

Pin matplotlib to < 3.6#959

Merged
nfahlgren merged 1 commit intomainfrom
pin-matplotlib-version
Sep 19, 2022
Merged

Pin matplotlib to < 3.6#959
nfahlgren merged 1 commit intomainfrom
pin-matplotlib-version

Conversation

@nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Sep 19, 2022

Describe your changes
Temporarily pin matplotlib to < v3.6 due to issues with plotnine. After merging, sync changes with the 4.x and release-4.0 branches.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

matplotlib v3.6 seems to break plotnine
@nfahlgren nfahlgren added the bugfix Bug fixes label Sep 19, 2022
@nfahlgren nfahlgren added this to the PlantCV v3.14.2 milestone Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #959 (6669d70) into main (73863a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         6011      6011           
=========================================
  Hits          6011      6011           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit 6e972dc into main Sep 19, 2022
@nfahlgren nfahlgren deleted the pin-matplotlib-version branch September 19, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants