Update sample_images to handle phenodata datasets#925
Merged
Conversation
Note: test images are empty files, real images are not needed for testing sampling
Closed
Codecov Report
@@ Coverage Diff @@
## 4.x #925 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 160 160
Lines 6799 6826 +27
=========================================
+ Hits 6799 6826 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HaleySchuhl
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
plantcv.utils.sample_images(used byplantcv-utils.py sample_images) was not updated to handlephenodatadatasets (see #923). This PR refactorssample_imagesto modularize the code and adds a sampling method forphenodatadatasets.Type of update
Is this a: Bug fix
Associated issues
Closes #923
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md