Skip to content

Mock dask cluster in tests#1925

Merged
nfahlgren merged 1 commit into
mainfrom
mock-dask-cluster-test
May 22, 2026
Merged

Mock dask cluster in tests#1925
nfahlgren merged 1 commit into
mainfrom
mock-dask-cluster-test

Conversation

@nfahlgren

@nfahlgren nfahlgren commented May 16, 2026

Copy link
Copy Markdown
Member

Describe your changes
Mocks the dask cluster and client in testing. The tests pass on GitHub Actions but were failing locally.

Type of update
Is this a: enhancement to testing

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.11 milestone May 16, 2026
@nfahlgren nfahlgren added testing Features related to testing and deployment ready to review labels May 16, 2026
@github-project-automation github-project-automation Bot moved this to Pull Requests in PlantCV4 May 16, 2026
@deepsource-io

deepsource-io Bot commented May 16, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 4785ba8...c29985e on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python May 16, 2026 11:02p.m. Review ↗
Code coverage May 16, 2026 11:02p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner joshqsumner self-requested a review May 22, 2026 15:49

@joshqsumner joshqsumner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works locally for me, looks good

@nfahlgren nfahlgren merged commit 8621fb8 into main May 22, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Requests to Done in PlantCV4 May 22, 2026
@nfahlgren nfahlgren deleted the mock-dask-cluster-test branch May 22, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review testing Features related to testing and deployment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants