Skip to content

add segment_width to morphology tools #1844

Merged
nfahlgren merged 38 commits intomainfrom
add-analyze-width
Nov 22, 2025
Merged

add segment_width to morphology tools #1844
nfahlgren merged 38 commits intomainfrom
add-analyze-width

Conversation

@HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Nov 13, 2025

Describe your changes
Add segment_width which uses a distance transformation to measure width of objects.

Type of update
Is this a:

  • New feature
  • Work in progress
  • add max width, and standard dev.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added this to the PlantCV v4.10 milestone Nov 13, 2025
@HaleySchuhl HaleySchuhl added new feature New feature ideas and solutions work in progress Mark work in progress labels Nov 13, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Nov 13, 2025
@deepsource-io
Copy link

deepsource-io bot commented Nov 13, 2025

Here's the code health analysis summary for commits 17d1077..1794df9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl changed the title Add segment_width to morphology tools Update version of vega-altair and add segment_width to morphology tools Nov 13, 2025
@HaleySchuhl HaleySchuhl changed the title Update version of vega-altair and add segment_width to morphology tools add segment_width to morphology tools Nov 13, 2025
@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Nov 14, 2025
@joshqsumner joshqsumner self-requested a review November 14, 2025 19:56
Copy link
Contributor

@joshqsumner joshqsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, my unfamiliarity with the morphology subpackage aside.

Looking through the docs it seems like it isn't super consistent on if we format function names as code or not, I pushed one commit to make them all code-formatted in the segment_width page but feel free to roll that back if there is a reason for some to be in different styles.

@nfahlgren nfahlgren merged commit d99a37b into main Nov 22, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Nov 22, 2025
@nfahlgren nfahlgren deleted the add-analyze-width branch November 22, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature ideas and solutions ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants