Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
still return interactive plot in hyper_hist, but remove from the chart getting passed to _debug because interactive plots will not respect dpi/ppi
HaleySchuhl
approved these changes
Oct 10, 2025
Contributor
HaleySchuhl
left a comment
HaleySchuhl
left a comment
There was a problem hiding this comment.
Works nicely. I was not seeing a difference in the saved output from pcv.visualize.hyper_histogram, but it's definitely having an impact on the chart saved out while running pcv.analyze.spectral_reflectance and pcv.analyze.grayscale.
pcv.visualize.hyper_histogram appears to ignore the ppi setting because it's interactive. If I remove .interactive() then dpi/ppi is respected. so I changed the code slightly so it still returns an interactive plot, but _debug is passed a static version so it'll respect the dpi.
color_correction.py, histogram.py, and obj_size_ecdf.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When you save a PNG image with Altair you can set the output PPI resolution, this PR applies the PlantCV
params.dpisetting to thepplinput.Type of update
Is this a: New feature or feature enhancement
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md