Skip to content

visualize.histogram complexity#1782

Merged
nfahlgren merged 5 commits intomainfrom
histogram-complexity
Sep 24, 2025
Merged

visualize.histogram complexity#1782
nfahlgren merged 5 commits intomainfrom
histogram-complexity

Conversation

@joshqsumner
Copy link
Contributor

@joshqsumner joshqsumner commented Sep 9, 2025

Describe your changes
Trying to reduce complexity in visualize.histogram.

Type of update
Is this a deepsource cyclomatic complexity edit.

Associated issues
None

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added work in progress Mark work in progress cleanup Code quality updates labels Sep 9, 2025
@deepsource-io
Copy link

deepsource-io bot commented Sep 9, 2025

Here's the code health analysis summary for commits b46852b..e9d92c6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@joshqsumner joshqsumner added ready to review and removed work in progress Mark work in progress labels Sep 9, 2025
@joshqsumner joshqsumner changed the title simplifying logic visualize.histogram complexity Sep 12, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Sep 24, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.10 milestone Sep 24, 2025
@nfahlgren nfahlgren merged commit 57124b7 into main Sep 24, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Sep 24, 2025
@nfahlgren nfahlgren deleted the histogram-complexity branch September 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality updates ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants