Skip to content

function import syntax update to resolve circular import deepsource issues#1777

Merged
nfahlgren merged 3 commits intomainfrom
circular_import_syntax
Sep 8, 2025
Merged

function import syntax update to resolve circular import deepsource issues#1777
nfahlgren merged 3 commits intomainfrom
circular_import_syntax

Conversation

@HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Sep 4, 2025

Describe your changes
Test syntax to resolve circular import complaints from Deepsource.

Type of update
Is this a:

  • code cleanup

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io
Copy link

deepsource-io bot commented Sep 4, 2025

Here's the code health analysis summary for commits 24c6d69..1a5b67b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 123 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl added the work in progress Mark work in progress label Sep 4, 2025
@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Sep 5, 2025
@HaleySchuhl HaleySchuhl changed the title test syntax update for circular import resolve function import syntax update to resolve circular import deepsource issues Sep 5, 2025
@nfahlgren nfahlgren added the cleanup Code quality updates label Sep 8, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Sep 8, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.10 milestone Sep 8, 2025
@nfahlgren nfahlgren merged commit f8c600d into main Sep 8, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Sep 8, 2025
@nfahlgren nfahlgren deleted the circular_import_syntax branch September 8, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality updates ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants