Skip to content

Rect multi roi#1764

Merged
nfahlgren merged 13 commits intomainfrom
rect-multi-roi
Aug 29, 2025
Merged

Rect multi roi#1764
nfahlgren merged 13 commits intomainfrom
rect-multi-roi

Conversation

@joshqsumner
Copy link
Contributor

@joshqsumner joshqsumner commented Aug 22, 2025

Describe your changes
Adds a multiple rectangular ROI function using h/w and top left corners based off of roi.multi.

This is a new feature.

Closes 1629

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added the new feature New feature ideas and solutions label Aug 22, 2025
@deepsource-io
Copy link

deepsource-io bot commented Aug 22, 2025

Here's the code health analysis summary for commits 6a6b5fd..65ca036. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is helpful in multi-leaf PSII imaging.

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to resolve read_url error.

@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Aug 29, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.10 milestone Aug 29, 2025
@nfahlgren nfahlgren merged commit b6961e7 into main Aug 29, 2025
5 checks passed
@nfahlgren nfahlgren deleted the rect-multi-roi branch August 29, 2025 20:50
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature ideas and solutions ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

rectangular multi roi

3 participants