Skip to content

Add cymk threshold custom range#1763

Merged
nfahlgren merged 10 commits intomainfrom
add-cymk-threshold-custom-range
Aug 27, 2025
Merged

Add cymk threshold custom range#1763
nfahlgren merged 10 commits intomainfrom
add-cymk-threshold-custom-range

Conversation

@HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Aug 21, 2025

Describe your changes
Add CYMK colorspace support to pcv.threshold.custom_range. Also adds two helper functions to reduce code redundancy within this function.

Type of update
Is this a:

  • feature enhancement

Associated issues

Additional context

  • Does not change the number of returns, propose in v5.0 we deprecate the mask_img return and make this function consistent with single-returns of other threshold subpackage functions.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added this to the PlantCV v4.10 milestone Aug 21, 2025
@HaleySchuhl HaleySchuhl added the enhancement Enhancements to existing features label Aug 21, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Aug 21, 2025
@deepsource-io
Copy link

deepsource-io bot commented Aug 21, 2025

Here's the code health analysis summary for commits 5a5f2c1..f18467d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl added the work in progress Mark work in progress label Aug 21, 2025
@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Aug 22, 2025
@joshqsumner joshqsumner self-requested a review August 26, 2025 19:19
Copy link
Contributor

@joshqsumner joshqsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nfahlgren nfahlgren merged commit 6a6b5fd into main Aug 27, 2025
5 checks passed
@nfahlgren nfahlgren deleted the add-cymk-threshold-custom-range branch August 27, 2025 16:43
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements to existing features ready to review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

threshold.custom_range outputs and CMYK

3 participants