Skip to content

1676 kmeans spectral#1688

Open
k034b363 wants to merge 56 commits intov5.0from
1676-kmeans-spectral
Open

1676 kmeans spectral#1688
k034b363 wants to merge 56 commits intov5.0from
1676-kmeans-spectral

Conversation

@k034b363
Copy link
Contributor

@k034b363 k034b363 commented Apr 1, 2025

Describe your changes
This PR adds the option to use hyperspectral images as input for kmeans clustering. It has been suggested that using more bands might help distinguish plant features that are otherwise difficult to tell apart.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Closes #1682 and #1676

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added enhancement Enhancements to existing features work in progress Mark work in progress labels Apr 1, 2025
@k034b363 k034b363 added this to the PlantCV v4.x milestone Apr 1, 2025
@k034b363 k034b363 self-assigned this Apr 1, 2025
@k034b363 k034b363 linked an issue Apr 1, 2025 that may be closed by this pull request
@deepsource-io
Copy link

deepsource-io bot commented Apr 1, 2025

Here's the code health analysis summary for commits a3a0eab..dc2b623. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage❌ Failure
❗ 3 occurences introduced
🚨 1 failing metric
View Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.9% (down 0.1% from main)99.9% (down 0.1% from main)
Line Coverage99.9% (down 0.1% from main)99.9% (down 0.1% from main)
New Branch Coverage100%100%
New Composite Coverage96.7%96.7%
New Line Coverage96.7%, ❌ Below Threshold96.7%, ❌ Below Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren modified the milestones: PlantCV v4.x, PlantCV v5.0 Nov 21, 2025
@joshqsumner joshqsumner changed the base branch from main to v5.0 February 6, 2026 21:38
@joshqsumner
Copy link
Contributor

I merged some stuff into this to be downstream of image-sharpening where I had split params and outputs into a _globals module to define singletons with less chance for import complaints which also points this at v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements to existing features work in progress Mark work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow kmeans to use hyper spectral images Kmeans training step should check for numpy arrays

3 participants