Add deprecation warning about label from the detect color card function#1664
Merged
Add deprecation warning about label from the detect color card function#1664
label from the detect color card function#1664Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Add space in warning for clarity.
Add space in warning for clarity.
k034b363
approved these changes
Jan 27, 2025
label from the detect color card functionlabel from the detect color card function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a deprecation warning that we plan to remove the
labelparameter input fromdetect_color_cardandauto_correct_color(since the trait of chip size is now a metadata term and therefore doesn't utilize a label).Type of update
Is this a:
Associated issues
Additional context
Technically a breaking change compared to before the chip size was converted to a metadata term.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md