Json2csv update: handle lists of coordinates#1652
Closed
HaleySchuhl wants to merge 5 commits intomainfrom
Closed
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Contributor
Author
|
Need to refine these updates for handling lists of coordinates. The changes so far resolve the fatal error when trying to read the csv output in Python with Refine based on the downstream use case, such as calculating distance matrices with leaf tip coordinates (for segment ID assignment between timepoints for example). |
8 tasks
Contributor
Author
|
Closing in favor of a different approach described in #1857 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adjust the
json2csvutility function to handle lists of coordinates e.g. leaf tip coordinates from the morphology subpackage.Type of update
Is this a:
json2csvwould run but would have squished syntax, and this bad syntax would throw an error while reading the resulting csv in withpandasas a dataframe)Associated issues
Additional context

Changes the formatting for coordinate-type outputs, where we have multi-value traits that are lists of points. Updated output format looks like this:
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md