Skip to content

Conversation

@danfimov
Copy link
Owner

closes #17

Copilot AI review requested due to automatic review settings October 11, 2025 00:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for psycopg3 as a PostgreSQL driver alongside the existing asyncpg, psqlpy, and aiopg drivers. The implementation includes a complete broker, result backend, and schedule source for psycopg3, along with comprehensive integration tests.

Key Changes:

  • Implementation of PsycopgBroker, PsycopgResultBackend, and PsycopgScheduleSource
  • Refactored integration tests to use fixtures and reduce duplication
  • Updated existing broker implementations to use private attributes for connections
  • Added database cleanup fixtures for better test isolation

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/taskiq_pg/psycopg/*.py New psycopg3 implementation files (broker, result backend, schedule source, queries, init)
src/taskiq_pg/psqlpy/broker.py Refactored to use private attributes and removed redundant null checks
src/taskiq_pg/psqlpy/schedule_source.py Updated to use JSONB type wrapper for schedule data
src/taskiq_pg/asyncpg/broker.py Refactored to use private attributes and added listener cleanup
tests/integration/test_broker.py New consolidated broker tests with fixtures
tests/integration/test_schedule_source.py Refactored tests with fixtures and added psycopg support
tests/integration/test_result_backend.py Added psycopg to parameterized tests
tests/integration/conftest.py Added database cleanup and connection fixtures
pyproject.toml Added psycopg dependency and sqlalchemy-utils for tests
docs/index.md, README.md Updated documentation with psycopg examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@danfimov danfimov force-pushed the add-schedule-source branch from e8d7342 to 4767bf8 Compare October 11, 2025 01:08
@danfimov danfimov merged commit c870142 into main Oct 11, 2025
4 checks passed
@danfimov danfimov deleted the add-schedule-source branch October 11, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for psycopg3

2 participants