fix rtl numeric list #655
Merged
fix rtl numeric list #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Turns out bidi reordering is not needed as all list counters we currently generate are ltr ordered. + Add padding-right in default style-sheet at-least for the case where direction is set directly on the ol element. + Direction can be ltr, rtl or auto.
Owner
|
Thanks heaps @johnnyaug, I have added a commit with a test and a couple of fixes. Sorry, I led you astray with bidi reordering. Not required after all as all generated list markers are ltr anyway. Thanks again and I will merge tomorrow unless you have any objections. |
Contributor
Author
|
@danfickle thanks! Any chance we can release a version? |
Owner
|
I still want to fix #641 but hopefully I can release on weekend (2020-03-06ish). Thanks again @johnnyaug. |
Owner
|
1.0.7 finally released. Apologies for being very late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #645