Fix link shapes #477 #480
Merged
Fix link shapes #477 #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason we only want the DPI scaling from the given transform, and not any other property of the transform. When adding a link to process later, the transform has at that moment also a translate in it. Before 1ffd271 the used transform was after the last page was processed. At that moment the transform only had a scale component and no translate.
Yes, those classes are copies, so there is duplication. But before extending this method I rather have it only in one place.
…ing box of the shape.
Owner
|
Hi @rototor, sorry for breaking this. After merging this pr, I'll try to create a basic test in non visual regression test so I don't break it again. Thanks again. |
danfickle
added a commit
that referenced
this pull request
May 18, 2020
As promised @rototor. Link shapes are working perfectly in Acrobat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the scaling from the given transform
For whatever reason we only want the DPI scaling from the given transform, and
not any other property of the transform.
When adding a link to process later, the transform has at that moment also a translate in it.
Before 1ffd271 the used transform was after the last page was
processed. At that moment the transform only had a scale component and no translate.