Class to functional components #193

Willjianger9 · 2025-11-20T01:14:30Z

No description provided.

NarekGermirlian · 2025-11-24T05:43:17Z

pages/arts.jsx

+    <p>
+      Oops! We meant to redirect you to https://dailybruin.com/category/arts
+    </p>;


Make sure you return inside the if statement; otherwise, we're not doing anything with the

<p>text</p>

tags

NarekGermirlian · 2025-11-24T05:48:42Z

pages/arts.jsx

+    // Redirect
+    window.location.href = "https://dailybruin.com/category/arts-entertainment";


Put this in a useEffect, so that it only runs once (otherwise, this will run every time the component is re-rendered).

NarekGermirlian · 2025-11-24T05:53:00Z

pages/daily-bruin-intern-descriptions.jsx

+Page.getInitialProps = async (context) => {
+  const { slug } = context.query;


To me it looks like we can get rid of slug (and thus context), as they are never used.

NarekGermirlian · 2025-11-24T05:53:52Z

pages/editorial-board.jsx

+Page.getInitialProps = async (context) => {
+  const { slug } = context.query;


Can get rid of context and slug here

NarekGermirlian · 2025-11-24T06:00:43Z

pages/category/spectrum.jsx

+    // const subcategoriesRes = await fetch(
+    //   `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${category[0].id}`
+    // );
+    // const subcategories = [await subcategoriesRes.json()];
+    // for (let i = 0; i < subcategories.length; i++) {
+    //   const subsubcategoriesRes = await fetch(
+    //     `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${subcategories[i].id}`
+    //   );
+    //   subcategories[i].subsubcategories = await subsubcategoriesRes.json();
+    // }


get rid of unecessary comments

NarekGermirlian · 2025-11-24T06:01:34Z

pages/category/spectrum.jsx

+  const postsLinks = posts.map((category, index) => {
    return (
-      <>
-        <Head>
-          <title>{this.props.category[0].name + " - Daily Bruin"}</title>
-        </Head>
-        <div style={{ padding: "6px" }}>
-          <SectionHeader
-            category={this.props.category[0].name}
-            subcategories={sectionLinks}
-          />
-        </div>
-        <MultimediaLayout
-          posts={this.props.posts}
-          categoryID={this.props.category[0].id}
+      <ul key={index}>
+        <li>
+          <Link
+            as={`/category/${category.slug}`}
+            href={`/category?slug=${category.slug}&apiRoute=category`}
+          >
+            <a>{category.title.rendered}</a>
+          </Link>
+        </li>
+      </ul>
+    );
+  });


looks like postsLinks is never used - can get rid of it.

NarekGermirlian · 2025-11-24T06:07:40Z

pages/category/uncategorized.jsx

 // Should take precedence over [slug].jsx
 import PageWrapper from "../../layouts/PageWrapper";
-import React, { Component } from "react";
+import React from "react";
 import Error from "next/error";

-class Uncategorized extends Component {
-  render() {
-    return <Error statusCode={404} />;
-  }
+function Uncategorized() {
+  return <Error statusCode={404} />;
 }

 export default PageWrapper(Uncategorized);


The more i look at it, I don't think this page is ever used. Can go ahead and get rid of it.

NarekGermirlian · 2025-11-24T06:54:51Z

pages/category/[slug].jsx

can remove Component from import

NarekGermirlian · 2025-11-24T06:57:03Z

pages/category/breaking/index.jsx

+    );
 }

+Tag.getInitialProps = async (context) => {


Don't need context parameter

NarekGermirlian · 2025-11-24T07:03:29Z

pages/category/cartoons.jsx

+    // const subcategoriesRes = await fetch(
+    //   `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${category[0].id}`
+    // );
+    // const subcategories = await subcategoriesRes.json();
+    // for (let i = 0; i < subcategories.length; i++) {
+    //   const subsubcategoriesRes = await fetch(
+    //     `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${subcategories[i].id}`
+    //   );
+    //   subcategories[i].subsubcategories = await subsubcategoriesRes.json();
+    // }


Can get rid of unnecessary comments

NarekGermirlian · 2025-11-24T07:20:14Z

pages/category/cartoons.jsx

+Cartoons.getInitialProps = async (context) => {
+  const { slug } = context.query;


slug and context are not needed

NarekGermirlian · 2025-11-24T07:21:11Z

pages/category/graphics.jsx

+    // const subcategoriesRes = await fetch(
+    //   `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${category[0].id}`
+    // );
+    // const subcategories = await subcategoriesRes.json();
+    // for (let i = 0; i < subcategories.length; i++) {
+    //   const subsubcategoriesRes = await fetch(
+    //     `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${subcategories[i].id}`
+    //   );
+    //   subcategories[i].subsubcategories = await subsubcategoriesRes.json();
+    // }


can get rid of unneeded comments

NarekGermirlian · 2025-11-24T07:21:28Z

pages/category/graphics.jsx

+Graphics.getInitialProps = async (context) => {
+  const { slug } = context.query;


slug and context unneeded

NarekGermirlian · 2025-11-24T07:22:28Z

pages/category/illo.jsx

+    // const subcategoriesRes = await fetch(
+    //   `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${category[0].id}`
+    // );
+    // const subcategories = await subcategoriesRes.json();
+    // for (let i = 0; i < subcategories.length; i++) {
+    //   const subsubcategoriesRes = await fetch(
+    //     `${Config.apiUrl}/wp-json/wp/v2/categories?parent=${subcategories[i].id}`
+    //   );
+    //   subcategories[i].subsubcategories = await subsubcategoriesRes.json();
+    // }


get rid of unneeded comments

NarekGermirlian · 2025-11-24T07:31:33Z

pages/sports.jsx

Same issues as arts page:

return the p tags

useEffect for redirect

NarekGermirlian · 2025-11-24T07:37:33Z

pages/comment.jsx

+Page.getInitialProps = async (context) => {
+  const { slug } = context.query;


don't need slug & context

NarekGermirlian · 2025-11-24T07:39:07Z

pages/privacy.jsx

+Page.getInitialProps = async (context) => {
+  const { slug } = context.query;


unneeded slug & context. i'll stop writing this for other pages, but just remove unneeded slug & context for the rest of your changes

NarekGermirlian · 2025-11-24T07:51:28Z

pages/index.jsx

remove unnecessary imports

showWelcome/setShowWelcome is unused

NarekGermirlian · 2025-11-24T08:27:25Z

pages/page/[slug].jsx

This page doesn't even work, but it also didn't work previous to your change. I'll bring this up to my boss to see if it's even being used (maybe we can get rid of it — will get back to you on this)

Willjianger9 · 2025-12-01T04:00:10Z

@NarekGermirlian Can i get another review twin Im pretty sure I addressed everything you brought up

NarekGermirlian

LGTM

Willjianger9 added 27 commits October 29, 2025 19:25

Converted class to functional component for Page in privacy.jsx

5c16865

Converted submit

c95e791

Converted requests

a8e3d3d

Community guide conversion

e64da5f

Tag pages conversion

b20262c

Sports conversion

3ecfdd0

sponsored conversion

82a0f73

quad conversion

d6a6c0d

Convert pages/post/[slug].jsx from class to functional component

1b095ac

Convert pages/page/[slug].jsx from class to functional component

97ec94e

opinion conversion from class to functional

d7b3228

new conversion from class to functional

41fd8a9

arts conversion

796a801

join conversion

7d4f3ff

editorial conversion

799ed7c

intern desc converison

7aa18e8

comment conversion

f9456f6

home page conversion

df12f4f

infocus conversion

e014976

video conversion

88282f5

uncategorized conversion

d6194e1

Spectrum conversion

f2c57f8

podcasts conversion

aaaad31

illo conversion

83db5a3

graphics conversion

916da5c

cartoon conv

ff26655

Rest of conversions

e79732b

NarekGermirlian requested review from NarekGermirlian and jishk11 November 20, 2025 03:53

NarekGermirlian reviewed Nov 24, 2025

View reviewed changes

pages/category/[slug].jsx

Copy link

Collaborator

NarekGermirlian Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove Component from import

Willjianger9 reacted with thumbs up emoji

NarekGermirlian reviewed Nov 24, 2025

View reviewed changes

NarekGermirlian requested changes Nov 24, 2025

View reviewed changes

Willjianger9 added 2 commits November 30, 2025 19:49

PR changes

e12506f

Fix

e8db42c

NarekGermirlian approved these changes Dec 17, 2025

View reviewed changes

Merge branch 'master' into class-to-functional-components

43320e4

NarekGermirlian merged commit d0f293a into master Dec 17, 2025

		// Redirect
		window.location.href = "https://dailybruin.com/category/arts-entertainment";

		Page.getInitialProps = async (context) => {
		const { slug } = context.query;

		Cartoons.getInitialProps = async (context) => {
		const { slug } = context.query;

		Graphics.getInitialProps = async (context) => {
		const { slug } = context.query;

Class to functional components #193

Class to functional components #193

Uh oh!

Conversation

Willjianger9 commented Nov 20, 2025

Uh oh!

NarekGermirlian Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Willjianger9 commented Dec 1, 2025

Uh oh!

NarekGermirlian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NarekGermirlian Nov 24, 2025 •

edited

Loading