Skip to content

Fix forward slashes problem in relative symlink targets on Windows #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakonhagland wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix forward slashes problem in relative symlink targets on Windows #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aee530f
Fix realpath for symlinks on windows.
hakonhagland Nov 18, 2022
74e55cd
lstat->size returns zero on Windows
hakonhagland Nov 19, 2022
9e833f0
Fix forward slashes in symlink target on Windows
hakonhagland Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions t/filesystem.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,10 +417,17 @@ SKIP: {
$file->spew("Hello World\n");
skip "symlink unavailable", 1 unless has_symlinks();
eval { symlink $file => $link };
ok( $link->lstat->size, "lstat" );

is( $link->realpath, $file->realpath, "realpath resolves symlinks" );

if ($^O eq "MSWin32") {
ok( $link->lstat->size == 0, "lstat->size returns zero on Windows" );
}
else {
ok( $link->lstat->size, "lstat->size returns nonzero" );
}
SKIP: {
skip "realpath of symlink not working correctly on Windows for perl <= 5.37.5"
if $^O eq "MSWin32" and "$]" <= 5.037005;
is( $link->realpath, $file->realpath, "realpath resolves symlinks" );
}
ok $link->remove, 'remove symbolic link';
ok $file->remove;

Expand Down
8 changes: 6 additions & 2 deletions t/symlinks.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ subtest "relative symlinks with updir" => sub {
my $foo = $td->child(qw/tmp foo/)->touch;
my $bar = $td->child(qw/tmp tmp2 bar/);

symlink "../foo", $bar or die "Failed to symlink: $!\n";
my $relpath = "../foo";
# Account for a bug in Win32 API, see https://github.com/Perl/perl5/issues/20506
# for more information
$relpath = "..\\foo" if $^O eq "MSWin32";
symlink $relpath, $bar or die "Failed to symlink: $!\n";

ok -f $foo, "it's a file";
ok -l $bar, "it's a link";

is readlink $bar, "../foo", "the link seems right";
is readlink $bar, $relpath, "the link seems right";
is abs_path($bar), $foo, "abs_path gets's it right";

is $bar->realpath, $foo, "realpath get's it right";
Expand Down