Drop default action delay back to 4 seconds#227
Merged
Conversation
PR #226 had bumped the default from 4s to 6s as a hedge against Android shuffling the BT stream volume late during route setup. On-device verification with AirPods Pro 2 on a Pixel 8 shows the route is stable well before 4s elapse and volume changes land at the intended target with no shuffle. Two seconds shaved off the typical connect-to-stable time for users who never customized actionDelay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #226 had bumped the default
actionDelayfrom 4s to 6s as a defensive hedge against a hypothetical "Android shuffles BT stream volume late during route setup" scenario. On-device verification with AirPods Pro 2 on a Pixel 8 shows the BT route stabilizes well before 4s elapse — volume changes land at the intended target and stay there, no shuffle. The 6s margin was load-bearing for no observable problem.Reverting to 4s saves ~2s of the user-perceived connect time for everyone on the default. Users on slower routes who need longer can still customize per-device in advanced settings.
Test plan
./gradlew testFossDebugUnitTest(594 pass)./gradlew testGplayDebugUnitTest(594 pass)volumeObserving + autoplay + musicVolume=100%: connect pipeline completes cleanly at the user's target volume, music starts after volume settled.