This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Voronoi.find(x,y,radius) #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Used here, as an example, to simplify @nbremer 's superb Voronoi interactivity system http://bl.ocks.org/Fil/f49b5cf943a0210212994aa5860ac4a8 |
|
Really excited for this 😬 |
mbostock
reviewed
Oct 27, 2016
| if (ndist < dist) { | ||
| dist = ndist; | ||
| next = ea.index; | ||
| return; |
Member
There was a problem hiding this comment.
This return has no effect within array.forEach, since there isn’t anything else to do in this function. Did you want to terminate iterating over the halfedges for the current cell in this case? My guess is you want to check all the halfedges regardless, but I could be wrong.
Member
Author
There was a problem hiding this comment.
you're right on both counts:
- I'd be happy with the first good result (doesn't need to be the best)
returndoesn't do what I want, so we end up checking all halfedges
Member
There was a problem hiding this comment.
Okay, I’ve merged it, but feel free to send a followup PR if you want to make improvements. Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #17