Add d3.pathRound.

[mbostock]

Fixes #10, taking option 2.

[mbostock]

I’m pretty sure we don’t want to introduce the overhead of calling the identity function in the common case, which means a lot of code duplication.

issue of overhead vs duplication

[Fil]

Now trying to call this._format as parsimoniously as possible; in the standard case _format return +x. I hope this limits the overhead.

(I'll review the git pseudo-conflicts situation if the approach seems acceptable.)

[mbostock]

I think of format as something that takes a number and returns a string. Relying on format to return a number (and taking arbitrary input) suggests that “format” is the wrong name.

Did you overwrite the original commits?

[Fil]

Hmm it looks like I force-pushed over your original commit ( 7b1c410 ) in June 2019, after a rebase.

[Fil]

should we name this function this._number?

[Fil]

yet another rebase, sorry—this has me struggling

Reference commits are: 7b1c410 (original) and 2897aa6 (rebase against branch two)

[mbostock]

I’ve updated this to take a cleaner approach using an internal tagged template literal, and changed d3.pathFixed so that it defaults digits to three (which matches number.toLocaleString and seems like a very reasonable default). I think this is ready to go.

[Fil]

love the templating approach!

[mbostock]

The latest commit switches to rounding per performance recommendations in #10 and d3/d3-geo#272 (comment).

[Fil]

🏇