Skip to content

remove connection and query deadlocks #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lethalwp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove connection and query deadlocks #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions connector/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ type SSHConnection struct {

// RunCommand runs a command against the device
func (c *SSHConnection) RunCommand(cmd string) ([]byte, error) {
c.mu.Lock()
defer c.mu.Unlock()
// c.mu.Lock()
// defer c.mu.Unlock()

if c.client == nil {
return nil, errors.New("not connected")
Expand Down
4 changes: 2 additions & 2 deletions connector/connection_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ func NewConnectionManager(opts ...Option) *SSHConnectionManager {

// Connect connects to a device or returns an long living connection
func (m *SSHConnectionManager) Connect(device *Device) (*SSHConnection, error) {
m.mu.Lock()
defer m.mu.Unlock()
// m.mu.Lock()
// defer m.mu.Unlock()

if connection, found := m.connections[device.Host]; found {
if !connection.isConnected() {
Expand Down