The network context menu is now closed on mouse-down events -- CW-697#530
Closed
chrtannus wants to merge 10 commits into
Closed
The network context menu is now closed on mouse-down events -- CW-697#530chrtannus wants to merge 10 commits into
chrtannus wants to merge 10 commits into
Conversation
Fix inverted reverse-colors logic, remove false success on error report branches, add NDEx summary filtering, shallow copy attributes to prevent mutation, remove unused imports, and remove render-time log spam. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fetchNdexSummaries returns NetworkSummary[] with required externalId, so the undefined checks were dead code. Keep only the size threshold filter as suggested in review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: address PR #505 review comments
- Fix stale workspace state in useDeleteCyNetwork by reading fresh store state after deletion - Remove unused ListItemButton import from ListEditor - Include nodeCount/edgeCount in updateNetwork summary update to prevent stale counts - Replace Number.parseInt with Number() in NumberEditor to preserve decimal values - Simplify MergeDialog createNetworkSummary using spread instead of field-by-field copy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address Copilot review: Number('') === 0 would silently overwrite values
when clearing the input. Now uses event.target.valueAsNumber (NaN for
empty/invalid input, skipped), and truncates for Integer/Long types
while preserving decimals for Double.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: address PR #505 review comments (items 13-17)
Context: JIRA ticket CW-667 reported that checkboxes were not working for service apps. Specifically, once a checkbox was checked or if it had a default value of 'true', it could not be unchecked in the UI. Bug: The bug was in . The 'checked' prop of the Checkbox component was using a logical OR operator: `parameter.value === 'true' || parameter.defaultValue === 'true'` This meant that if the property had a default value of 'true', the checkbox would always be rendered as checked, regardless of the user's interaction (which updates `parameter.value`). Fix: The fix uses the nullish coalescing operator to prioritize the user-specified `value`, falling back to `defaultValue` if `value` is undefined (initial state): `(parameter.value ?? parameter.defaultValue) === 'true'` This ensures that if a user unchecks the box (setting `value` to 'false'), the UI correctly reflects the unchecked state.
fix(CW-667): fix service app checkbox checked state logic
❌ Deploy Preview for voluble-rugelach-5a3809 failed. Why did it fail? →
|
Member
IIRC, it has to prevent propagation on some events, but we could revisit this. Another option may be to |
Member
|
Merging this to the 1.0.7 branch |
Member
|
Moving to #533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this is the most elegant solution, but after several other failed attempts, this workaround works just fine.
I really don't understand why the MUI Menu component is not closed automatically.
@maxkfranz I think it may be something related to cytoscape.js, because the other menus (in the menu bar) also have the same issue if you click the cytoscape canvas (they do close when clicking the other sections of the UI). So maybe cytoscape is stealing the events?
Issue: CW-697