Skip to content

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Nov 4, 2025

Additional details

Steps to test

How has the user experience changed?

PR Tasks


Note

Renames the Cypress.Exec result field from code to exitCode and adds a changelog note reflecting the correct cy.exec() type.

  • Types:
    • In cli/types/cypress.d.ts, rename Exec.code to Exec.exitCode to match the actual cy.exec() result.
  • Changelog:
    • Add entry noting cy.exec() now yields exitCode in type definitions (cli/CHANGELOG.md).

Written by Cursor Bugbot for commit f0b741e. This will update automatically on new commits. Configure here.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I missed this one. Thank you for fixing it!

@cypress
Copy link

cypress bot commented Nov 4, 2025

cypress    Run #67114

Run Properties:  status check failed Failed #67114  •  git commit f0b741e4f7: add changelog entry
Project cypress
Branch Review fix-exec-type
Run status status check failed Failed #67114
Run duration 19m 58s
Commit git commit f0b741e4f7: add changelog entry
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 11
Tests that did not run due to a developer annotating a test with .skip  Pending 1098
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26506
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.61%
  Untested elements 187  
  Tested elements 161  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  src/specs/generators/ExpandableFileChooser.cy.tsx • 1 failed test • app-ct

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

@jennifer-shehane jennifer-shehane merged commit 56c04cd into develop Nov 4, 2025
86 of 91 checks passed
@jennifer-shehane jennifer-shehane deleted the fix-exec-type branch November 4, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v15] cy.exec return type incorrect, code should be renamed to exitCode

4 participants