openat2: increase retry count to 128 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen reports of users hitting the 32 retry limit, hopefully a 4x increase is enough to ease the pain. Ultimately, as a result of commit 02d2e4b ("gopathrs: return raw errors from openat2 retry loop") it is practical for callers to do their own top-level infinite retry loop if intermittent failures are unacceptable for their use-case. Signed-off-by: Aleksa Sarai <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 31, 2025
yeazelm
added a commit
to bottlerocket-os/bottlerocket-core-kit
that referenced
this pull request
Nov 5, 2025
Bump the retry counter to 128 from 32 for vendored depenedency to handle situations where there is a lot of resource contention. This is taken from 28c6340c68213ca07e2cc715f33495681ebd1792 in filepath-securejoin as part of cyphar/filepath-securejoin#76 Signed-off-by: Matthew Yeazel <[email protected]> Reviewed-by: Kyle Sessions <[email protected]> Reviewed-by: Ben Cressey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen reports of users hitting the 32 retry limit, hopefully a 4x
increase is enough to ease the pain. Ultimately, as a result of commit
02d2e4b ("gopathrs: return raw errors from openat2 retry loop") it
is practical for callers to do their own top-level infinite retry loop
if intermittent failures are unacceptable for their use-case.
Signed-off-by: Aleksa Sarai [email protected]