Conversation
cbf34bf to
4b5b2f3
Compare
d0f88ca to
82604ba
Compare
|
I'm changing this PR to a draft until cyberark/go-mssqldb#30 is merged in, because I'll have to update the submodule ref. |
|
Builds failing. Appears to be a Red Hat issue. and Github Actions: |
12434e8 to
bea1f4e
Compare
Fixes build failing due to goconvey dependency change
|
Builds seem to have been broken by |
f6950a2 to
86a828b
Compare
8b75c62 to
dc8ca29
Compare
pkg/k8sclient/clientset/versioned/typed/secretless.io/v1/fake/fake_configuration.go
Show resolved
Hide resolved
pkg/k8sclient/clientset/versioned/typed/secretless.io/v1/fake/fake_configuration.go
Show resolved
Hide resolved
pkg/k8sclient/clientset/versioned/typed/secretless.io/v1/configuration.go
Show resolved
Hide resolved
495a847 to
2cb9dcc
Compare
k8s.io/api v0.22.3 k8s.io/apiextensions-apiserver v0.22.3 k8s.io/apimachinery v0.22.3 k8s.io/client-go v0.22.3
Satisfy new function signatures after K8S package updates.
2cb9dcc to
c6ac63a
Compare
* Fixes `bin/codegen` script * Updates `Dockerfile.codegen` to use correct upsteam `kubernetes/code-generator` repo tag matching K8S packages * Fix permission denied deleting temp dirs by deleting within Docker context
c6ac63a to
a1e4384
Compare
…ODO()` false positives
a1e4384 to
32c7cd7
Compare
32c7cd7 to
2e520e3
Compare
|
Code Climate has analyzed commit 2e520e3 and detected 53 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.8% (0.0% change). View more on Code Climate. |
|
Note to merger: Don't squash commits when merging - "Rebase and merge" |
diverdane
left a comment
There was a problem hiding this comment.
LGTM!!! Thank you so much for taking care of this!
Fixes build failing due to goconvey dependency change. Depends on cyberark/go-mssqldb#30
Desired Outcome
Jenkins builds of Docker images do NOT fail with errors such as the following:
Implemented Changes
go.modis upgraded from Go v1.15 to Go v1.16.go env -w GOFLAGS=-mod=modis run in containers to fix this module issue in go1.16go mod tidyto fix build breaking due to this issuebin/codegenscriptDockerfile.codegento use correct upsteamkubernetes/code-generatorrepo tag matching K8S packagescontext.TODO()false positivesConnected Issue/Story
Incidentally resolves #1387
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security