Update PATTERNS_PATH, resolves issue #8 #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @SecurityRepo in issue #8, the tool would not return any potential vulnerabilities when used as a command-line tool. When using git-vuln-finder as a library, I received the error message:
The issue is when loading the patterns, the PATTERNS_PATH was hard-coded to "./git_vuln_finder/patterns" and this path changes when installed; therefore, it would not load any patterns to search against. The path needs to be loaded dynamically: os.path.dirname(os.path.abspath(_ file _)) + "/patterns"
Once I made the change, git-vuln-finder started to return results. I have opened a pull request to resolve issue #8.
Thanks!