-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Improved consensus UX #10172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved consensus UX #10172
Changes from 35 commits
5a3be48
7c3860e
d36613c
ba89329
90ffefc
ed75514
393f1de
8512b9a
16424a5
7988880
bea545e
1fa189a
208aba0
3793157
dc6d57e
6154d0f
663b0b9
7a19846
8e20888
26721b7
276cd7b
b476772
c665f0b
8089afc
74265ee
0f7cc7e
1ece322
2b8c22f
4569110
61471d1
a812cfc
e52824b
5458874
cd8f540
92ea3fb
577ba9d
a5fa2fe
e5ffb4e
8b7f9d5
3392e30
c1c9a76
9ee7aa7
5c6c40a
7389029
cb74fde
5c0d397
7b448f4
a57c681
a6cc1ae
b38b875
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ### Changed | ||
|
|
||
| - Consensus merge function now preserves all shapes with their scores, regardless of quorum threshold | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
| - In review mode, all annotations are locked by default; Users can unlock and edit individual annotations as needed | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
| - Next/Previous object navigation (`Shift+Tab`/`Shift`) now works in Standard, Review, Attribute Annotation workspaces | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
klakhov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ### Added | ||
|
|
||
| - Score visualization in UI with a virtual "Votes" attribute calculated as `score × replica_jobs` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This formula can stop working if we allow job creation after merging, will need to understand how to handle it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that may be an issue. But for now, as we discussed, we’ll explicitly mention in the documentation that this value is UI-only and approximate. |
||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
| - Double-clicking an object in the sidebar now centers it on the canvas and expands its details | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
|
|
||
| ### Removed | ||
| - Consensus `quorum` setting | ||
klakhov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
bsekachev marked this conversation as resolved.
Show resolved
Hide resolved
klakhov marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -377,7 +377,6 @@ export interface SerializedQualityReportData { | |
| export interface SerializedConsensusSettingsData { | ||
| id?: number; | ||
| task?: number; | ||
| quorum?: number; | ||
| iou_threshold?: number; | ||
| descriptions?: Record<string, string>; | ||
| } | ||
|
|
@@ -423,8 +422,9 @@ export interface SerializedShape { | |
| group: number; | ||
| frame: number; | ||
| source: Source; | ||
| score?: number; | ||
| attributes: { spec_id: number; value: string }[]; | ||
| elements: Omit<SerializedShape, 'elements'>[]; | ||
| elements: Omit<SerializedShape, 'elements' | 'score'>[]; | ||
|
||
| occluded: boolean; | ||
| outside: boolean; | ||
| points?: number[]; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.