-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Improved consensus UX #10172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improved consensus UX #10172
Changes from 44 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
5a3be48
Initial implementation
klakhov 7c3860e
Merge branch 'develop' into kl/consensus-ux
klakhov d36613c
Fix score visualization
klakhov ba89329
Add virtual votes text
klakhov 90ffefc
Make next/prev object shortcuts global
klakhov ed75514
Update votes logic to be stored in object
klakhov 393f1de
Merge branch 'develop' into kl/consensus-ux
klakhov 8512b9a
Display score on sidebar
klakhov 16424a5
Add score and votes to annotation filters
klakhov 7988880
Update review mode
klakhov bea545e
Clean-up comments
klakhov 1fa189a
fix linters
klakhov 208aba0
Fix save bug with score
klakhov 3793157
Update schema
klakhov dc6d57e
Scroll into view when using shortcuts
klakhov 6154d0f
Expand object details when object is focused
klakhov 663b0b9
Added feature: double click on object on sidebar expands it and focuses
klakhov 7a19846
Add changelog
klakhov 8e20888
Remove `quorum`
klakhov 26721b7
Update changelog
klakhov 276cd7b
Merge branch 'develop' into kl/consensus-ux
klakhov b476772
Fix server tests
klakhov c665f0b
Update changelog
klakhov 8089afc
Restore quorum param as 0 for default datumaro config
klakhov 74265ee
Tmp disable consensus tests (need to rewrite them)
klakhov 0f7cc7e
More fixes
klakhov 1ece322
Merge branch 'develop' into kl/consensus-ux
klakhov 2b8c22f
Fix: score only for labeled shapes
klakhov 4569110
Fix black
klakhov 61471d1
Update one more asset
klakhov a812cfc
Add suggested fix: transform keyframes to shapes
klakhov e52824b
Add 'consensus' source in skeleton elements
klakhov 5458874
Remove 'consensus_score' attr as not used
klakhov cd8f540
Small updates
klakhov 92ea3fb
Fix turple error
klakhov 577ba9d
Merge branch 'develop' into kl/consensus-ux
klakhov a5fa2fe
Preserve consensus source and always show score/votes for such objects
klakhov e5ffb4e
Add tooltip and margin
klakhov 8b7f9d5
Updated changelog
klakhov 3392e30
Add score to skeleton elements
klakhov c1c9a76
Update annotation filter
klakhov 9ee7aa7
Merge branch 'develop' into kl/consensus-ux
klakhov 5c6c40a
Use proxy approach with lock in review mode
klakhov 7389029
Remove readonly attr where it is always false
klakhov cb74fde
Update tooltip align
klakhov 5c0d397
Make score read-only
klakhov 7b448f4
Fix unit tests
klakhov a57c681
Apply minor comments
klakhov a6cc1ae
Fix linter
klakhov b38b875
Merge branch 'develop' into kl/consensus-ux
klakhov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| ### Changed | ||
|
|
||
| - Consensus merge function now preserves all shapes with their scores, regardless of quorum threshold | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
|
|
||
| ### Added | ||
|
|
||
| - Score visualization in UI with a virtual "Votes" attribute calculated as `score × replica_jobs` | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
| - A user now may navigate between different shapes with shortcuts (Tab/Shift+Tab by default) in Standard, Review modes | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
| - Review mode now supports editing objects. Users can unlock and edit individual annotations as needed | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
| - Double-clicking an object in the sidebar now centers it on the canvas and expands its details | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
|
|
||
| ### Removed | ||
| - Consensus quorum setting has been removed. All merged annotations are now kept with their consensus scores, | ||
| allowing users to filter results based on score thresholds instead | ||
| (<https://github.com/cvat-ai/cvat/pull/10172>) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev marked this conversation as resolved.
Show resolved
Hide resolved
klakhov marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formula can stop working if we allow job creation after merging, will need to understand how to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that may be an issue. But for now, as we discussed, we’ll explicitly mention in the documentation that this value is UI-only and approximate.