-
Notifications
You must be signed in to change notification settings - Fork 13
Fix packages #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packages #196
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/curaos/frontend/3RHjefMcRmFcYcuM9DcB3TkUcuir |
|
Hey @AshenI99, there was an issue before where when we used The main component which was affected is Can you please make sure it works for you and no other problems shows up. Also now, I think when doing Thank you :)) The original issue: #114 (comment) |
AshenI99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NFTE component
- I deleted
distfolders inside every package. And then did a clean install. - Then imported NFTE in frontend to test it.
- Seems like all are working well.
Component inside storybook
- Hot reloading of hooks is working without any issue with
yarn dev:components.
And right now, dist folders aren't creating with yarn dev:frontend. So it is using src folders directly from the packages.
Good Job. 👍
|
🎉 This PR is included in version @cura/hooks-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @cura/components-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
links
overview
Now, when developing the
@cura/componentswill use@cura/hooksfrom the local folder, but when published it will get replaced with latest version from NPMAnd thanks to
publishConfig, we can use the files fromsrc/in developement and replaced withdist/when publishing