Skip to content

Conversation

@TheLubab
Copy link
Contributor

@TheLubab TheLubab commented Dec 24, 2021

links

overview

Now, when developing the @cura/components will use @cura/hooks from the local folder, but when published it will get replaced with latest version from NPM

And thanks to publishConfig, we can use the files from src/ in developement and replaced with dist/ when publishing

@vercel
Copy link

vercel bot commented Dec 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/frontend/3RHjefMcRmFcYcuM9DcB3TkUcuir
✅ Preview: https://frontend-git-fixpackages-curaos.vercel.app

@TheLubab TheLubab linked an issue Dec 24, 2021 that may be closed by this pull request
@TheLubab
Copy link
Contributor Author

TheLubab commented Dec 24, 2021

Hey @AshenI99, there was an issue before where when we used @cura/hooks inside @cura/components it will fail. (This issue were only happening when doing a clean install and deleting dist folder. )

The main component which was affected is NFTE, and Yassine disabled it, now I enabled it again and tried to fix it.

Can you please make sure it works for you and no other problems shows up.

Also now, I think when doing yarn dev:components, the hooks package should get hot reloaded. Can you make sure that works too.

Thank you :))

The original issue: #114 (comment)

@TheLubab TheLubab requested a review from AshenI99 December 24, 2021 10:09
Copy link
Collaborator

@AshenI99 AshenI99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NFTE component

  • I deleted dist folders inside every package. And then did a clean install.
  • Then imported NFTE in frontend to test it.
  • Seems like all are working well.

Component inside storybook

  • Hot reloading of hooks is working without any issue with yarn dev:components.

And right now, dist folders aren't creating with yarn dev:frontend. So it is using src folders directly from the packages.

Good Job. 👍

@TheLubab TheLubab self-assigned this Dec 25, 2021
@bestatigen bestatigen merged commit 9ea7e9a into master Dec 28, 2021
@TheLubab TheLubab deleted the fix_packages branch December 30, 2021 16:56
@github-actions
Copy link

🎉 This PR is included in version @cura/hooks-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @cura/components-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in CI deployment of Storybook for components with hooks

4 participants