Skip to content

Conversation

@mikelolasagasti
Copy link
Contributor

🤔 What's changed?

Project was using non-modularized version of github.com/gofrs/uuid. This change switches to module github.com/google/uuid.

gofrs has a v5 version that could be used also, but I tend to use Google's module in my projects.

When using Google's module, New() is equal of doing uuid.Must(uuid.NewRandom()), so the change mimics the old uuid.Must(uuid.NewV4()) code but it's shorter.

⚡️ What's your motivation?

Using updated modules in the project.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:


Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But please also update the CHANGELOG with an entry under changed.

Also change import order to make `gofumpt` happy.

Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
@mikelolasagasti
Copy link
Contributor Author

Updated CHANGELOG file, let me know if I need to change something else.

In the last version I also changed the import order in messages_test.go to make gofumpt pass.

@mpkorstanje mpkorstanje merged commit 34b5049 into cucumber:main Sep 12, 2024
@mpkorstanje
Copy link
Contributor

Cheers!

If you are using Godog, you might want to update the version of messages used in Gherkin too. It's currently behind a few versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants