Skip to content

Conversation

@TjarkMiener
Copy link
Member

This PR adds a tool to translate DL2 files from lstchain to ctapipe data format.

@TjarkMiener TjarkMiener changed the base branch from main to lst-testdata December 9, 2025 08:36
@TjarkMiener
Copy link
Member Author

It is failing to download the testdata even I changed the base to the latest PR of @maxnoe, where the CI is passing. Can you please help? Thanks in advance!

@maxnoe
Copy link
Member

maxnoe commented Dec 9, 2025

@rlopezcoto @moralejo #1391 needs to be merged, so that other PRs can download test data again.

Base automatically changed from lst-testdata to main December 9, 2025 11:38
@TjarkMiener
Copy link
Member Author

@rlopezcoto @moralejo #1391 needs to be merged, so that other PRs can download test data again.

@maxnoe unfortunately, it is not solving the issue. Also the CI on the main is failing.

@maxnoe
Copy link
Member

maxnoe commented Dec 10, 2025

That's actually unrelated (downloading test data worked on main), it's the release of pytest v9 that turned a warning into an error.

@TjarkMiener
Copy link
Member Author

@maxnoe any suggestion how the authentication issue in this PR can be solved? Thanks in advance!

@maxnoe
Copy link
Member

maxnoe commented Dec 10, 2025

You need to update with main (assuming you have no local changes):

git switch dl2_convert
git fetch
git rebase origin/main
git push -f

@TjarkMiener TjarkMiener force-pushed the dl2_convert branch 2 times, most recently from 33553a6 to 36f36aa Compare December 10, 2025 15:55
@TjarkMiener TjarkMiener changed the base branch from main to fix-pytest December 10, 2025 15:56
@TjarkMiener TjarkMiener force-pushed the dl2_convert branch 2 times, most recently from 44b4408 to e276d3a Compare December 10, 2025 16:27
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 98.21429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.15%. Comparing base (1ae21d4) to head (805a34b).
⚠️ Report is 6 commits behind head on fix-pytest.

Files with missing lines Patch % Lines
lstchain/tools/lstchain_dl2_converter.py 98.08% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           fix-pytest    #1393      +/-   ##
==============================================
+ Coverage       84.92%   85.15%   +0.23%     
==============================================
  Files              94       95       +1     
  Lines            9487     9655     +168     
==============================================
+ Hits             8057     8222     +165     
- Misses           1430     1433       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TjarkMiener TjarkMiener marked this pull request as ready for review December 10, 2025 17:10
@moralejo moralejo merged commit ebe4f50 into fix-pytest Dec 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants