Skip to content

install artifacts return False if requested solc versions are not available #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023
Merged

install artifacts return False if requested solc versions are not available #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions solc_select/solc_select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ def installed_versions() -> [str]:
def install_artifacts(versions: [str]) -> bool:
releases = get_available_versions()

if "all" not in versions:
not_available_versions = list(set(versions).difference([*releases]))
if not_available_versions:
print(f"{', '.join(not_available_versions)} solc versions are not available.")
return False

for version, artifact in releases.items():
if "all" not in versions:
if versions and version not in versions:
Expand Down