fix: guard against None func in convert_type_of_high_and_internal_level_call (#2375)#2984
Open
aayushbaluni wants to merge 1 commit intocrytic:masterfrom
Open
Conversation
…el_call (crytic#2375) Root cause: Vyper interface calls with default args (e.g. def f(x=0)) omit the arg when calling; len(ir.arguments) != len(f.parameters) so lookup fails. Code then accessed func.type while func was None, causing AttributeError.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2375.
Root cause: Vyper interface calls with default arguments (e.g.
def price_oracle(i: uint256 = 0)) omit the argument when calling (Pool(a).price_oracle()). The function lookup filters bylen(f.parameters) == len(ir.arguments), so the interface function is excluded.funcremains None, but the code then accessedfunc.type, causingAttributeError: 'NoneType' object has no attribute 'type'.Fix: Add a guard when
funcis None: setir.lvalue = Noneand return early instead of accessingfunc.type.Changes
slither/slithir/convert.py: Addif func is Nonecheck before accessingfunc.typeinconvert_type_of_high_and_internal_level_callTesting
def price_oracle(i: uint256 = 0)and callPool(a).price_oracle()no longer crashesMade with Cursor