Skip to content

Conversation

@maximebuyse
Copy link
Contributor

@maximebuyse maximebuyse commented Oct 1, 2025

This will maximize compatibility for crates using hax with a version of cargo older than 1.85.0.

@maximebuyse maximebuyse requested a review from a team as a code owner October 1, 2025 08:55
@maximebuyse maximebuyse requested a review from W95Psp October 1, 2025 08:55
@W95Psp
Copy link
Member

W95Psp commented Oct 1, 2025

Ah, putting no edition at all will default to Rust from 10 years ago or something I believe :O
Could we just use edition 2021?
Switching to edition 2021 will likely require zero change to the code

(I think requiring 2021 is not crazy)

@maximebuyse
Copy link
Contributor Author

Ah, putting no edition at all will default to Rust from 10 years ago or something I believe :O Could we just use edition 2021? Switching to edition 2021 will likely require zero change to the code

(I think requiring 2021 is not crazy)

Yes, I hesitated between both solutions. I'll try 2021 which seems reasonable indeed.

@W95Psp
Copy link
Member

W95Psp commented Oct 1, 2025

👍 let's make it 2021 then, it's what we can call "modern Rust", otherwise we have to think pretty legacy things

@maximebuyse maximebuyse changed the title Remove edition for hax-lib to maximize compatibility for crates using hax. Switch hax-lib to Rust edition 2021. Oct 1, 2025
@maximebuyse maximebuyse enabled auto-merge October 1, 2025 09:38
@maximebuyse maximebuyse added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit d6f9f61 Oct 1, 2025
22 of 24 checks passed
@maximebuyse maximebuyse deleted the hax-lib-no-edition branch October 1, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants