Improve rustc caching with cargo-hax
#1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
cargo-hax-fix-caching
branch
from
a146ba1 to
141f778
Compare
W95Psp
requested review from
maximebuyse
and removed request for
clementblaudeau
maximebuyse
approved these changes
Sep 29, 2025
Contributor
maximebuyse
left a comment
maximebuyse
left a comment
There was a problem hiding this comment.
Looks good (I just added one question).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1720
This PR:
Optionsin two, so that the options send fromcargo-haxto our custom rustc driver are narrowerExporterOptionsinstead of fullOptions. Rustc cache is invalidated whenever those options change. Thus, now changing an engine-only option will not causerustcto recompile the crate being extracted.