Update Lean printer to new infrastructure #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If the monolithic change is too hard to review, I can try to break it down into smaller pieces, but it's a non negligible amount of work. |
W95Psp
approved these changes
Aug 20, 2025
Member
W95Psp
left a comment
W95Psp
left a comment
There was a problem hiding this comment.
Thanks, looks good to me, I have a few minor comments.
Member
franziskuskiefer
left a comment
franziskuskiefer
left a comment
There was a problem hiding this comment.
Just a nit and a question.
Co-authored-by: Lucas Franceschino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1603.
It updates the Lean backend to the new printing infrastructure.
Context
#1603 and #1600 added new infrastructure for printing, based on the return of experience of the Lean printer. Specifically, they introduced a proper notion of backend/printer, and some utils for writing
docs.This PR
This PR updates the Lean backend to the new infrastructure, which unfortunately makes for a monolithic swap. It should not make any semantic changes, besides whitespace and two library edits :
usizeis nowUsize,u8is nowUInt8, etcabbrev RustVector := Array. The fact that Lean and Rust have opposite terminology was a source of confusion