Skip to content

hax-lib: Int improvements and fixes #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
W95Psp merged 8 commits into from
Mar 26, 2025
Merged

hax-lib: Int improvements and fixes #1372

W95Psp merged 8 commits into from
Mar 26, 2025

Conversation

@W95Psp
Copy link
Member

@W95Psp W95Psp commented Mar 25, 2025

This PR:

  • fix BigInt::new
  • add overflowing_sub F* model for u64
  • derives display for Int
  • add F* defintion for Int::pow2
  • adapt names (because of rework naming PR)
  • add rem_euclid for Int

@W95Psp W95Psp requested a review from a team as a code owner March 25, 2025 05:44
@W95Psp W95Psp requested a review from maximebuyse March 25, 2025 05:45
@W95Psp W95Psp force-pushed the hax-lib-int-fixes branch from ec19dbd to 7a5b182 Compare March 25, 2025 06:24
maximebuyse
maximebuyse approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@W95Psp W95Psp force-pushed the hax-lib-int-fixes branch from 1a41b22 to 6794a0f Compare March 26, 2025 09:54
@W95Psp W95Psp enabled auto-merge March 26, 2025 09:54
@W95Psp W95Psp added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 40ecdbe Mar 26, 2025
16 checks passed
@W95Psp W95Psp deleted the hax-lib-int-fixes branch March 26, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximebuyse maximebuyse maximebuyse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@W95Psp @maximebuyse