Skip to content

Fix publicKeyVerify length check #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanatid merged 1 commit into from
Apr 27, 2020
+6 −2
Merged

Fix publicKeyVerify length check #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/elliptic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ function loadPublicKey (pubkey) {
switch (first) {
case 0x02:
case 0x03:
// if (pubkey.length !== 33) return null
if (pubkey.length !== 33) return null
return loadCompressedPublicKey(first, pubkey.subarray(1, 33))
case 0x04:
case 0x06:
case 0x07:
// if (pubkey.length !== 65) return null
if (pubkey.length !== 65) return null
return loadUncompressedPublicKey(first, pubkey.subarray(1, 33), pubkey.subarray(33, 65))
default:
return null
Expand Down
4 changes: 4 additions & 0 deletions test/publickey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ module.exports = (t, secp256k1) => {
invalidY[64] ^= 0x01
t.false(secp256k1.publicKeyVerify(invalidY), 'invalid Y')

const invalidLength = Buffer.from(publicKey.uncompressed)
invalidLength[0] = publicKey.compressed[0]
t.false(secp256k1.publicKeyVerify(invalidLength), 'invalid length')

t.end()
})

Expand Down