Skip to content

Conversation

@k9ert
Copy link
Contributor

@k9ert k9ert commented May 17, 2024

  • migrate the downloadpage generation script to this repo and updated the release-guide.md (+ autosave changes also in self-signed-certificates.md))
  • set the target for the build to universalwhich is unfortunately mostly undocumented (issue).
  • Some missing or misguided variable declarations in the refactored electron app which caused:
    • specter-desktop didn't terminate properly
    • Seeing transaction details results in a crashing app
    • Saving preferences was not possible

@netlify
Copy link

netlify bot commented May 17, 2024

Deploy Preview for specter-desktop-docs ready!

Name Link
🔨 Latest commit 3ca0765
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/664df2de67fc6d0008fce8e9
😎 Deploy Preview https://deploy-preview-2441--specter-desktop-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k9ert k9ert mentioned this pull request May 22, 2024
Copy link
Collaborator

@moneymanolis moneymanolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the electron app and everything seems to work, nicely done!

@k9ert k9ert changed the title Miscellaneous Changes Electron Bug Fixes and Miscellaneous Changes May 22, 2024
@k9ert k9ert merged commit 5f05b9a into cryptoadvance:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants