Skip to content

Conversation

@randy-cro
Copy link

@randy-cro randy-cro commented Aug 18, 2025

Rationale

These methods are irrelevant as our chain is POS and not POW.

References

https://github.com/cosmos/evm/pull/456/files

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@randy-cro randy-cro requested a review from a team as a code owner August 18, 2025 04:17
@randy-cro randy-cro requested review from JayT106 and thomas-nguy and removed request for a team August 18, 2025 04:17
@thomas-nguy thomas-nguy changed the title feat: remove non geth json rpc methods chore: remove unecessary json rpc methods Aug 18, 2025
@randy-cro randy-cro changed the title chore: remove unecessary json rpc methods feat: remove eth_hashrate and eth_mining json rpc methods Aug 18, 2025
@randy-cro randy-cro changed the title feat: remove eth_hashrate and eth_mining json rpc methods chore: remove eth_hashrate and eth_mining json rpc methods Aug 18, 2025
Copy link

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need to update the changelog

Copy link

@XinyuCRO XinyuCRO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also MinerNamespace declared in api, should we remove it as well?

@randy-cro randy-cro force-pushed the feat/remove-non-geth-json-rpc branch from 3ec0a13 to 80b168d Compare August 18, 2025 08:01
@randy-cro randy-cro merged commit d550ec0 into crypto-org-chain:develop Aug 18, 2025
38 checks passed
@randy-cro randy-cro deleted the feat/remove-non-geth-json-rpc branch August 18, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants